Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error async-component, state not reloaded after error #98

Open
peppescg opened this issue Feb 11, 2019 · 0 comments
Open

Error async-component, state not reloaded after error #98

peppescg opened this issue Feb 11, 2019 · 0 comments

Comments

@peppescg
Copy link

Hi @ctrlplusb I have a problem when a component has an error on resolving.
I am using async-component for decorating every routes.
If there are some connection troubles and I go to a specific not loaded route, the asyncComponent will render ErrorComponent or null. Great.

if (error) { return ErrorComponent ? React__default.createElement(ErrorComponent, _extends({}, this.props, { error: error })) : null; }

But after that, if change route, go to home page ( the connection is coming back ) and after that I try to go back to the route before ( the route that I had connection trouble ), the state of asyncComponent should not be dirty, the component will not be rendered, because I will have the same error, despite the connection is come back.

I suggest to add a prop for setting the state to default, in this way, the developer can decide to render again a component if it has an error.
What do you think?

@peppescg peppescg changed the title Error component state not reloaded after error Error async-component, state not reloaded after error Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant