Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't think frequency distribution is working #28

Open
odedniv opened this issue Oct 26, 2018 · 0 comments
Open

Don't think frequency distribution is working #28

odedniv opened this issue Oct 26, 2018 · 0 comments

Comments

@odedniv
Copy link

odedniv commented Oct 26, 2018

I'm not an expert in NLTK, but I tried following the algorithm and I don't understand how it can work.

It seems _build_frequency_dist is supposed to count frequency of phrases. However, the phrase_list it receives is the one generated by _generate_phrases which returns a set(), which means every phrase can only appear there once.

The generated Counter object counts every phrase as appearing once.

This doesn't make sense no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant