Skip to content

Latest commit

 

History

History
30 lines (21 loc) · 1.74 KB

CONTRIBUTING.md

File metadata and controls

30 lines (21 loc) · 1.74 KB
Raw

Contributing

Important notes

Please don't edit files in the dist subdirectory as they are generated via Grunt. You'll find source code in the src subdirectory!

Code style

Regarding code style like indentation and whitespace, follow the conventions you see used in the source already.

Testing

The project uses Karma Test Runner to do crossbrowser testing. It also runs PhantomJS by default during grunt default task. However PhantomJS shouldn't be considered a substitute for the real thing. Please be sure to test using karma in actual browsers.

Modifying the code

First, ensure that you have the latest Node.js, npm, Karma and PhantomJS installed.

Test that Grunt's CLI is installed by running grunt --version. If the command isn't found, run npm install -g grunt-cli. For more information about installing Grunt, see the getting started guide.

  1. Fork and clone the repo.
  2. Run npm install to install all dependencies (including Grunt).
  3. Run grunt to grunt this project.

Assuming that you don't see any red, you're ready to go. Just be sure to run grunt after making any changes, to ensure that nothing is broken. You may use grunt watch to let grunt watch for changes in source and test files.

Submitting pull requests

  1. Create a new branch, please don't work in your master branch directly.
  2. Add failing tests for the change you want to make. Run grunt to see the tests fail.
  3. Fix stuff.
  4. Run grunt to see if the tests pass. Repeat steps 2-4 until done.
  5. Update the documentation to reflect any changes.
  6. Push to your fork and submit a pull request.