You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we filter out a file through --filter-paths, Slither still wastes time analyzing that file, and only skips returning the results for it.
Is this not a bug?
Code example to reproduce the issue:
Not needed.
Version:
0.10.2
Relevant log output:
No response
The text was updated successfully, but these errors were encountered:
We don't currently filter out beforehand because a file that is filtered out may be referenced by other files e.g. library/parent contract in inheritance that must also be analyzed. In terms of performance, I would expect a higher priority is reducing the time we spend in solc (foundry-rs/foundry#7212). We do need to revisit Slither's performance though and I'm sure there's a way to more intelligently filter to eliminate this overhead.
Targeting a specific contract like src/ContractX.sol will skip analyzing others, so one would expect --filter-paths to behave similarly. Thank you for clarifying.
0xalpharush
changed the title
[Bug-Candidate]: Filtered out files are still analyzed
Filter paths before parsing and lowering AST when possible
Apr 11, 2024
Describe the issue:
When we filter out a file through --filter-paths, Slither still wastes time analyzing that file, and only skips returning the results for it.
Is this not a bug?
Code example to reproduce the issue:
Not needed.
Version:
0.10.2
Relevant log output:
No response
The text was updated successfully, but these errors were encountered: