You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What bug did Slither miss and which detector did you anticipate would catch it?
Clone the optimism repo and cd packages/contracts-bedrock.
Open L1Block.sol and in setL1BlockValuesEcotone, notice the unused let data := calldataload(4).
Update the slither.config.json so no checks are excluded.
Run slither . (side error: running slither ./src/L2/L1Block.sol gives a compilation error that I haven't looked into yet), which does not find the unused data variable.
Frequency
Not sure
Code example to reproduce the issue:
See above
Version:
0.10.0
Relevant log output:
No response
The text was updated successfully, but these errors were encountered:
Ah, I thought I'd seen unused variables in the past but perhaps unused-state-variable is what I was remembering. In which case, we can convert this into a feature request
0xalpharush
changed the title
[False Negative]: Unused variable in assembly not found
Detect unused local variables (including in Yul blocks)
Feb 20, 2024
What bug did Slither miss and which detector did you anticipate would catch it?
cd packages/contracts-bedrock
.L1Block.sol
and insetL1BlockValuesEcotone
, notice the unusedlet data := calldataload(4)
.slither.config.json
so no checks are excluded.slither .
(side error: runningslither ./src/L2/L1Block.sol
gives a compilation error that I haven't looked into yet), which does not find the unuseddata
variable.Frequency
Not sure
Code example to reproduce the issue:
See above
Version:
0.10.0
Relevant log output:
No response
The text was updated successfully, but these errors were encountered: