Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print menu item changes to document text after cancelling print #1478

Open
lucidcocoon opened this issue May 1, 2024 · 1 comment
Open
Labels
Bug There is a problem in our source code Code Related to the Markdown Code app Drive Anything related to CryptPad interface, not apps Junior friendly Something that should be quick and/or easy to fix UI/UX Interfaces & user experience

Comments

@lucidcocoon
Copy link

Description

I am able to get the "Print" menu item to change to the content of my Code markdown file simply by cancelling a print. The print button is still functional but it will not read "Print" again until I reload the page. Tested this in the latest Firefox on Opensuse Aeon.

In the following screenshot the markdown file contains the following:

This is a test

Screenshot 2024-05-02 at 00-04-36 Encrypted Code

I should also note that if I inspect the source code using the Firefox inspector tool, the code changes from this:

<li role="menuitem" tabindex="0">
  <a class="fa fa-print cp-toolbar-icon-print cp-toolbar-rightside-button" tabindex="-1" data-tippy="" data-original-title="Print your document or export it as a PDF file">
    <i class="undefined"></i>
    <span>Print</span>
  </a>
</li>

to this:

<li role="menuitem" tabindex="0">
  <p>This is a test</p>
</li>

Steps to reproduce

  1. Load https://cryptpad.fr/ as a guest and click Code
  2. Add some content to the file in the code editor pane
  3. Click on File > Print
  4. Click cancel on the print dialog
  5. Click on the File menu again

Relevant logs

No response

Expected behavior

The Print menu item should not have the content changed.

Which operating system are you using?

Linux/BSD/UNIX

What browsers are you seeing the problem on?

Mozilla Firefox

Extensions

None

Version

2024.3.0

@mathilde-cryptpad mathilde-cryptpad added the Code Related to the Markdown Code app label May 2, 2024
@mathilde-cryptpad mathilde-cryptpad changed the title Code App: Print menu item changes to document text after cancelling print Print menu item changes to document text after cancelling print May 2, 2024
@mathilde-cryptpad mathilde-cryptpad added the Bug There is a problem in our source code label May 2, 2024
@mathilde-cryptpad
Copy link
Contributor

Hello,

Thanks for your bug report, nice catch!

Here is a screenshot of how it looks after cancelling the print and trying to access the File menu again:

Screenshot 2024-05-02 at 09 10 52

Note that you don't have to be a guest user to reproduce, it happens for registered ones as well.

@mathilde-cryptpad mathilde-cryptpad added Drive Anything related to CryptPad interface, not apps UI/UX Interfaces & user experience labels May 2, 2024
@mathilde-cryptpad mathilde-cryptpad removed this from the Summer release (2024.6.0) milestone May 10, 2024
@mathilde-cryptpad mathilde-cryptpad added the Junior friendly Something that should be quick and/or easy to fix label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug There is a problem in our source code Code Related to the Markdown Code app Drive Anything related to CryptPad interface, not apps Junior friendly Something that should be quick and/or easy to fix UI/UX Interfaces & user experience
Projects
Status: No status
Development

No branches or pull requests

2 participants