-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Dark mode friendly PWA splash screen #93
Comments
I agree this would be a nice fix. |
Yet to be fixed with crypt.ee 3.0 |
Hey there! Funny thing is that we actually did fix this for v3.0 initially : web-client/source/imports/www/webapp-head.kit Lines 16 to 94 in 7ae4124
BUT. What's more is that your boot images may also get stuck on the install-moment orientation of your device (i.e. if you installed Cryptee while your iPad was in portrait mode, if you launch Cryptee in landscape the splash images stretch out to fill the screen 🤦🏻♂️ ) thx apple. Both are known webkit bugs, and hopefully someone will fix them soon. Here's a relevant thread if you'd like to read more about all the ios specific splash screen bugs. Until then, we had to make a choice to go with one or another. So we checked what other apps do, and majority of the ones we checked seemed be going with light-mode as default in these situations, so that's what we did. As soon as webkit fixes these bugs, we'll enable the dark mode splash screens. Hoping this makes sense! ✌🏻 |
Does the same apply to Blink-based browsers like Chromium? I experience similar situation with the Chromium Browser on my Android device |
@makkussu It's entirely possible! Pretty much every browser, blink-or-not, implement PWA manifests differently. Mainly because the idea of PWAs are still too new ( PWA installation flows / implementations differ even among blink-based browsers (and even operating systems) nowadays. Firefox introduced bunch of bugs with PWA installations recently, causing icons to appear white (#113) etc. All this aside, –funnily enough– the concept of "dark-mode" itself is still too new for the web & operating systems. |
Is your feature request related to a problem? Please describe.
I prefer the dark version of cryptee on my mobile device but this setting is not respected by the splash screen since that is most likely a hardcoded image.
Describe the solution you'd like
A dark mode friendly PWA splash screen which is either the standard or switches based on the theme selected by the user.
Additional context
n/a
The text was updated successfully, but these errors were encountered: