Remove TagSpecification from the EC2 instance spec
#2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmir
force-pushed
the
tag-at-creation-time-ec2
branch
2 times, most recently
from
cee6710
to
1584451
Compare
Instance parameters allows specifying tags in two methods: `TagSpecification` and `Tags`. These methods have different semantics - `TagSpecification` tags will be applied when the instance is created, `Tags` will be created in a separate `CreateTags` API call afterwards. All tags required to meet IAM policy must be specified in `TagSpecification`. Signed-off-by: justin.miron <justin.miron@reddit.com>
justinmir
force-pushed
the
tag-at-creation-time-ec2
branch
from
1584451
to
07b06ba
Compare
|
I'm very reluctant about introducing breaking changes to the API. Would it be possible to keep both fields but deprecate one and have both of them being merged together? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Instance parameters allows specifying tags in two methods:
TagSpecificationandTags. These methods have different semantics -TagSpecificationtags will be applied when the instance is created,Tagswill be created in a separateCreateTagsAPI call afterwards. All tags required to meet IAM policy must be specified inTagSpecification.Fixes #2024
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This code has been tested on and deployed in our own fork used in production.
This continues to test the RunInstancesInput generation unit test that was updated to match passing in tags via the
Tagsfield instead ofTagSpecification.