Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve movie search support #437

Closed
bakerboy448 opened this issue Jun 10, 2023 · 4 comments · Fixed by #640
Closed

Improve movie search support #437

bakerboy448 opened this issue Jun 10, 2023 · 4 comments · Fixed by #640
Labels
feature New feature or request integration Integration (API) with/for applications search Related to search

Comments

@bakerboy448
Copy link
Contributor

  • parse for tmdbid or imdbid from name or data searched and perform a Torznab movie search with the ids
  • Both id and name searches should be attempted
  • Improve parsing of movie titles to more clearly search the movie and year
@mmgoodnow
Copy link
Collaborator

I tried doing ?t=movie when I added ?t=tvsearch but it resulted in less matches than ?t=search. I could try again though. Are there other benefits to searching with ?t=movie over ?t=search?

Where do you suggest we find these tmdb/imdb ids? Using their apis?

@bakerboy448
Copy link
Contributor Author

imdbid / tmdbid / tvdbid should just tried to be parsed from the pushed title. If it's there, great use it (and S/E for sonarr). If not use the usual title logic

caps per tracker will indicate what search abilities are supported

@mmgoodnow
Copy link
Collaborator

mmgoodnow commented Jun 30, 2023 •
edited

Is it common for ids to be in the titles? Not sure I've seen this before.

caps per tracker will indicate what search abilities are supported

yeah, but what makes movie search better than plain search?

@bakerboy448
Copy link
Contributor Author

Starr recommended naming scheme is to include it in naming - so primary usecase would be data search of the library.

Free text search all vs. movie specific search is the high level. Torznab spec docs should have some more details

@zakkarry zakkarry added feature New feature or request search Related to search integration Integration (API) with/for applications labels Sep 28, 2023
@zakkarry zakkarry mentioned this issue Apr 19, 2024
Merged
zakkarry added a commit that referenced this issue May 23, 2024
@zakkarry @ShanaryS @mmgoodnow
feat(arr-lookup): fetch category and id caps for torznab searching (#640
bfefbbd 
)

closes #437


enhancement to search

- searches an added radarr or sonarr instances for respective movies or
tv in the local library/db (parse endpoint). parses out the appropriate
ids for searching
- improves the potential capabilities of media library searches
substantially in subsequent open PR, as well as foreign language
searches
    - requires indexer to have the id search caps listed
- only searches tv or movies ids on indexers with the corresponding
caps. no id searches on trackers that do not have it
- uses same "style" URL and queries as torznab, supports multiple
instances in string array
- reverts to old behavior if it cannot search ids or cannot find the
content in one of the arrs
- logging done in verbose/debug

---------

Co-authored-by: ShanaryS <shanarys@gmail.com>
Co-authored-by: Michael Goodnow <mmgoodnow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request integration Integration (API) with/for applications search Related to search
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(arr-lookup): fetch category and id caps for torznab searching cross-seed/cross-seed
3 participants
@mmgoodnow @bakerboy448 @zakkarry