Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(arr-lookup): fetch category and id caps for torznab searching #640

Merged
merged 25 commits into from May 23, 2024
Merged

feat(arr-lookup): fetch category and id caps for torznab searching #640

merged 25 commits into from May 23, 2024

Conversation

zakkarry
Copy link
Collaborator

@zakkarry zakkarry commented Apr 19, 2024 •
edited

closes #437

enhancement to search

  • searches an added radarr or sonarr instances for respective movies or tv in the local library/db (parse endpoint). parses out the appropriate ids for searching
    • improves the potential capabilities of media library searches substantially in subsequent open PR, as well as foreign language searches
    • requires indexer to have the id search caps listed
  • only searches tv or movies ids on indexers with the corresponding caps. no id searches on trackers that do not have it
  • uses same "style" URL and queries as torznab, supports multiple instances in string array
  • reverts to old behavior if it cannot search ids or cannot find the content in one of the arrs
  • logging done in verbose/debug

@zakkarry zakkarry added feature New feature or request search Related to search integration Integration (API) with/for applications labels Apr 19, 2024
@zakkarry zakkarry self-assigned this Apr 19, 2024
mmgoodnow
mmgoodnow reviewed Apr 19, 2024
View reviewed changes
Copy link
Collaborator

@mmgoodnow mmgoodnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general I think the approach looks good. I think there's probably some refactoring to make the arr ids not all require the same repetitive code. One way to think about it is that ideally, the code highlights the differences in behavior between the three ids, not the similarities.

src/logger.ts Outdated Show resolved Hide resolved
src/migrations/05-idcaps.ts Outdated Show resolved Hide resolved
src/migrations/05-idcaps.ts Outdated Show resolved Hide resolved
src/torznab.ts Outdated Show resolved Hide resolved
src/config.template.cjs Outdated Show resolved Hide resolved
src/torznab.ts Show resolved Hide resolved
src/torznab.ts Outdated Show resolved Hide resolved
src/torznab.ts Outdated Show resolved Hide resolved
src/torznab.ts Outdated Show resolved Hide resolved
src/torznab.ts Outdated Show resolved Hide resolved
@zakkarry
Copy link
Collaborator Author

rebased off v6-unstable and addressed pretty much everything i think?

@zakkarry zakkarry requested a review from mmgoodnow April 19, 2024 20:07
@ShanaryS
Copy link
Contributor

I updated filterTimestamps to filter by support category first. Also updated getTag to getMediaType.

8076f17 (#640)

@mmgoodnow
Copy link
Collaborator

I updated filterTimestamps to filter by support category first.

Thanks for that fix!

mmgoodnow
mmgoodnow approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@mmgoodnow mmgoodnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to merge, my one comment is non-blocking.

@zakkarry zakkarry merged commit bfefbbd into master May 23, 2024
5 checks passed
@zakkarry zakkarry deleted the id-search branch May 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickel stickel stickel left review comments

@ShanaryS ShanaryS ShanaryS left review comments

@mmgoodnow mmgoodnow mmgoodnow approved these changes

Assignees

@zakkarry zakkarry

Labels
bt client config related to config file daemon dependencies Pull requests that update a dependency file feature New feature or request integration Integration (API) with/for applications logging search Related to search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve movie search support
4 participants
@zakkarry @ShanaryS @mmgoodnow @stickel