Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect Retry-After header in Torznab queries #481

Merged
merged 3 commits into from Sep 12, 2023

Conversation

bakerboy448
Copy link
Contributor

@bakerboy448 bakerboy448 commented Sep 9, 2023

ToDo

  • cleanup initial chatgpt code 馃槄
  • Test
  • verbose logging?

Git Ref

@onedr0p
Copy link
Contributor

onedr0p commented Sep 9, 2023

I think the workflow needs to be updated to pull_request_target instead of pull_request so the tokens carry over.

https://github.com/cross-seed/cross-seed/blob/master/.github/workflows/ci.yml#L9

@mmgoodnow mmgoodnow changed the title (feat): Use Retry-After Headed in 429 if available (feat): Use Retry-After Header in 429 if available Sep 12, 2023
@mmgoodnow mmgoodnow changed the title (feat): Use Retry-After Header in 429 if available Respect Retry-After header in Torznab queries Sep 12, 2023
@mmgoodnow
Copy link
Collaborator

LGTM, lmk when you're ready for a merge.

@bakerboy448
Copy link
Contributor Author

changes look good. Probably should be tested, but also seems simple/logical enough to just Yeeet in 馃槄

@onedr0p
Copy link
Contributor

onedr0p commented Sep 12, 2023

Logic seems sound, unfortunate that we cannot test a container build of this PR, however it can be merged to master and built & tested there instead.

@mmgoodnow
Copy link
Collaborator

yolo

@mmgoodnow mmgoodnow merged commit aa0d1f0 into cross-seed:master Sep 12, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect Retry-After for grabs
3 participants