Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix *-solaris #1424

Closed
Emilgardis opened this issue Jan 31, 2024 · 1 comment · Fixed by #1495
Closed

Fix *-solaris #1424

Emilgardis opened this issue Jan 31, 2024 · 1 comment · Fixed by #1495
Labels
bug
Milestone
v0.3.0

Comments

@Emilgardis
Copy link
Member

CI fails for the solaris targets:

sparcv9-sun-solaris - ❌
x86_64-sun-solaris - ❌

strangly, I've never been able to catch the error this throws, I think the log is too large and GHA fails. We should maybe check that everything is correctly downloading, as I've seen logs just mentioning syncing of a particular ubuntu/debian repo
@Emilgardis Emilgardis added this to the v0.3.0 milestone Jan 31, 2024
@Emilgardis Emilgardis added the bug label Jan 31, 2024
@Emilgardis Emilgardis mentioned this issue Feb 1, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 6, 2024
@Emilgardis
disable/fix failing targets (#1432)
15ba0b1 
Touches on
#1422
#1423
#1424

resolves #1425 (kinda)
@thirteenowls
Copy link
Contributor

thirteenowls commented May 12, 2024 •
edited

I was curious about this, so I ran the two CI jobs on a private fork, and they both failed by running out of disk space.
However, GitHub only shows those errors on the summary page, and the job pages only show logs that suddenly stop, making it easy to miss.
The logs for the last *-solaris CI runs in this repo have expired so I can't check, but could this be the issue?

Looking at solaris.sh, it seems to try to install all packages that depend on libc (and more), which seems excessive.

Edit: I misread depends as rdepends, so the above is incorrect. It does pull in thousands of unnecessary packages, though (which it presumably wasn't doing previously).

@thirteenowls thirteenowls mentioned this issue May 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 17, 2024
@Emilgardis
Fix *-solaris targets (#1495)
19be834 
Fixes #1424.

Adapted from rust-lang/rust#108951 and
rust-lang/rust#81229 (with some minor changes to
satisfy ShellCheck and account for broken symlinks).

This PR also renames `x86_64-sun-solaris` to `x86_64-pc-solaris`, as the
former was [deprecated](rust-lang/rust#82216) in
Rust 1.52.0 and [removed](rust-lang/rust#118091)
in Rust 1.76.0, making this a breaking change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

Fix *-solaris targets thirteenowls/cross
2 participants
@Emilgardis @thirteenowls