Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release numpy.float fixes #8

Closed
bmegli opened this issue Apr 24, 2023 · 4 comments
Closed

release numpy.float fixes #8

bmegli opened this issue Apr 24, 2023 · 4 comments

Comments

@bmegli
Copy link

bmegli commented Apr 24, 2023

Hi @fsuarez6,

I am asking you as the author and official maintainer of the package.

Could the #7 fixes be released (bump package.xml version, bloom)?

With the removal of deprecated attributes in numpy, dependent ROS packages will now fail at runtime in noetic with updated numpy (e.g. pip version).

Some examples:

Kind regards


Edit:

  • clarified when the problem happens
@fsuarez6
Copy link
Member

I've reverted #7 and will work on a proper fix so that we don't break previous ROS packages

@bmegli
Copy link
Author

bmegli commented Apr 24, 2023

Also, the problem may not happen on clean Focal + Noetic.

The apt numpy version is 17.4 (before deprecation and expiry).

apt-cache policy python3-numpy
python3-numpy:
  Installed: 1:1.17.4-5ubuntu3.1
  Candidate: 1:1.17.4-5ubuntu3.1

So the problem stems from something else updating numpy through pip and overriding system version.
(for general public)

@bmegli
Copy link
Author

bmegli commented Apr 24, 2023

@fsuarez6, I am fine to close this issue.

After investigation:

  • clean Focal + Noetic should have older version of numpy that doesn't have this problem
  • problem is caused by pip installed numpy >= 1. 24.0

You may still want to figure out forward and backward compatible solution but this is not urgent.

@bmegli bmegli closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants