Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel downloads #48

Open
cmandesign opened this issue Mar 28, 2019 · 2 comments
Open

Parallel downloads #48

cmandesign opened this issue Mar 28, 2019 · 2 comments

Comments

@cmandesign
Copy link

Behaviour

Steps to reproduce this issue

  1. Make config file with proper credentials
  2. Start FTP Grabber
  3. FTP Grabber starts to download, but single file simultaneously

Expected behaviour

I expected to see multiple downloads when I set connection per host.

Actual behaviour

It only downloads files sequentially, one by one.

Configuration

  • FTPGrab version : 5.1.1
  • Platform : windows
  • Remote FTP : Filezilla-Server-windows

Logs

FTPGrab logs (set --log-level flag to debug and --log-ftp)

�[2mThu, 28 Mar 2019 10:09:00 UTC�[0m �[32mINF�[0m Starting FTPGrab 5.1.1
�[2mThu, 28 Mar 2019 10:09:00 UTC�[0m �[33mDBG�[0m {
  "Flags": {
    "Cfgfile": ".\\config_niko.yml",
    "Schedule": "",
    "Timezone": "UTC",
    "LogLevel": "debug",
    "LogJson": false,
    "LogFile": "",
    "Docker": false
  },
  "App": {
    "ID": "ftpgrab",
    "Name": "FTPGrab",
    "Desc": "Grab your files periodically from a remote FTP or SFTP server easily",
    "URL": "https://ftpgrab.github.io",
    "Author": "CrazyMax",
    "Version": "5.1.1"
  },
  "Server": {
    "Type": "ftp",
    "FTP": {
      "Host": "95.216.93.225",
      "Port": 21,
      "Username": "********",
      "Password": "********",
      "Sources": [
        "/Apex"
      ],
      "ConnectionsPerHost": 10,
      "Timeout": 5,
      "DisableEPSV": false,
      "TLS": {
        "Enable": false,
        "Implicit": true,
        "InsecureSkipVerify": false
      },
      "LogTrace": false
    },
    "SFTP": {
      "Host": "",
      "Port": 22,
      "Username": "********",
      "Password": "********",
      "Key": "********",
      "Sources": null,
      "Timeout": 30,
      "MaxPacketSize": 32768
    }
  },
  "Db": {
    "Enable": true,
    "Path": "apex_updater.db"
  },
  "Download": {
    "Output": "/Apex",
    "UID": 0,
    "GID": 0,
    "ChmodFile": 420,
    "ChmodDir": 493,
    "Include": null,
    "Exclude": null,
    "Since": "0001-01-01T00:00:00Z",
    "Retry": 3,
    "HideSkipped": false,
    "CreateBasedir": false
  },
  "Mail": {
    "Enable": false,
    "Host": "localhost",
    "Port": 25,
    "SSL": false,
    "InsecureSkipVerify": false,
    "Username": "********",
    "Password": "********",
    "From": "",
    "To": ""
  },
  "File": {
    "FileAttributes": 32,
    "CreationTime": {
      "LowDateTime": 2846841088,
      "HighDateTime": 30729172
    },
    "LastAccessTime": {
      "LowDateTime": 2846841088,
      "HighDateTime": 30729172
    },
    "LastWriteTime": {
      "LowDateTime": 45055992,
      "HighDateTime": 30729548
    },
    "FileSizeHigh": 0,
    "FileSizeLow": 532,
    "Reserved0": 0
  }
}
�[2mThu, 28 Mar 2019 10:09:00 UTC�[0m �[32mINF�[0m ########
�[2mThu, 28 Mar 2019 10:09:01 UTC�[0m �[33mDBG�[0m 0 entries found in database
�[2mThu, 28 Mar 2019 10:09:01 UTC�[0m �[32mINF�[0m ########
�[2mThu, 28 Mar 2019 10:09:01 UTC�[0m �[32mINF�[0m Grabbing from /Apex
�[2mThu, 28 Mar 2019 10:09:01 UTC�[0m �[32mINF�[0m --------
�[2mThu, 28 Mar 2019 10:09:01 UTC�[0m �[32mINF�[0m Checking /Apex/amd_ags_x64.dll
�[2mThu, 28 Mar 2019 10:09:01 UTC�[0m �[32mINF�[0m Already downloaded
�[2mThu, 28 Mar 2019 10:09:01 UTC�[0m �[31mWRN�[0m Skipped: Already downloaded
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[32mINF�[0m --------
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[32mINF�[0m Checking /Apex/audio/ship/audio.mprj
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[32mINF�[0m Already downloaded
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[31mWRN�[0m Skipped: Already downloaded
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[32mINF�[0m --------
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[32mINF�[0m Checking /Apex/audio/ship/general.mbnk
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[32mINF�[0m Exists but size is different
�[2mThu, 28 Mar 2019 10:09:02 UTC�[0m �[32mINF�[0m Downloading file (56.03MB) to /Apex/audio/ship/general.mbnk...
�[2mThu, 28 Mar 2019 10:16:32 UTC�[0m �[32mINF�[0m File successfully downloaded!
�[2mThu, 28 Mar 2019 10:16:32 UTC�[0m �[32mINF�[0m Time spent: 7 minutes
�[2mThu, 28 Mar 2019 10:16:32 UTC�[0m �[32mINF�[0m --------
�[2mThu, 28 Mar 2019 10:16:32 UTC�[0m �[32mINF�[0m Checking /Apex/audio/ship/general.mbnk_digest
�[2mThu, 28 Mar 2019 10:16:32 UTC�[0m �[32mINF�[0m Never downloaded
�[2mThu, 28 Mar 2019 10:16:32 UTC�[0m �[32mINF�[0m Downloading file (1.82MB) to /Apex/audio/ship/general.mbnk_digest...
�[2mThu, 28 Mar 2019 10:16:47 UTC�[0m �[32mINF�[0m File successfully downloaded!
�[2mThu, 28 Mar 2019 10:16:47 UTC�[0m �[32mINF�[0m Time spent: 14 seconds
�[2mThu, 28 Mar 2019 10:16:47 UTC�[0m �[32mINF�[0m --------
�[2mThu, 28 Mar 2019 10:16:47 UTC�[0m �[32mINF�[0m Checking /Apex/audio/ship/general_english.mstr
�[2mThu, 28 Mar 2019 10:16:47 UTC�[0m �[32mINF�[0m Never downloaded
�[2mThu, 28 Mar 2019 10:16:47 UTC�[0m �[32mINF�[0m Downloading file (848.7MB) to /Apex/audio/ship/general_english.mstr...
@crazy-max
Copy link
Owner

Thank you for the report, I understand better now. The ConnectionsPerHost setting is the maximum number of FTP connections per host. This one is useless and will be removed in the next version.
As far as simultaneous downloads are concerned, this is not yet in place but I will take into account your request 😉

@crazy-max crazy-max changed the title Connection per host is not working Multithreaded downloads Mar 28, 2019
@crazy-max crazy-max changed the title Multithreaded downloads Parallel downloads Mar 28, 2019
crazy-max added a commit that referenced this issue Oct 4, 2020
@crazy-max crazy-max mentioned this issue Oct 4, 2020
@stale

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants