Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdw/jdbc: Support and document adding additional jdbc drivers #15793

Open
mfussenegger opened this issue Apr 3, 2024 · 0 comments
Open

fdw/jdbc: Support and document adding additional jdbc drivers #15793

mfussenegger opened this issue Apr 3, 2024 · 0 comments
Labels
complexity: no estimate feature: fdw Foreign data wrapper needs discussion needs upvotes Please use the reaction feature on the issue to signal your interest. This helps us prioritize

Comments

@mfussenegger
Copy link
Member

mfussenegger commented Apr 3, 2024

Problem Statement

CrateDB only includes a PostgreSQL JDBC driver. FDW/JDBC can't be used to connect to other servers like MySQL or MSSQL.
It's not documented how a driver for a different server can be added.

There should also be a way to add drivers for docker/container deployments. Maybe via a dedicated external-libs folder and volume mounts.

Possible Solutions

Some options:

  • Document that jars can be placed into lib/
  • Add separate external-libs/ folder and setup volume mounts for the docker image. See if adding class-loader isolation is necessary to avoid JarHell if the dependency include duplicate classes.
  • Bundle more clients
  • Offer option to bundle clients on demand/download

Whatever option is taken, we also need to reconsider the "local" protection limitations as pointed out in #15776 (review)
(Worst case option could be something like changing fdw.allow_local to support never | if-unkown | always), where if-unknown is strict for the PostgreSQL case or if the URL parses as URI, but accepts it if it can't parse the URI safely.)

Considered Alternatives

No response

@mfussenegger mfussenegger added complexity: no estimate needs discussion needs upvotes Please use the reaction feature on the issue to signal your interest. This helps us prioritize feature: fdw Foreign data wrapper labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: no estimate feature: fdw Foreign data wrapper needs discussion needs upvotes Please use the reaction feature on the issue to signal your interest. This helps us prioritize
Projects
None yet
Development

No branches or pull requests

1 participant