Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching random generator #1

Open
bcleenders opened this issue Jan 12, 2015 · 0 comments
Open

Switching random generator #1

bcleenders opened this issue Jan 12, 2015 · 0 comments

Comments

@bcleenders
Copy link

Maybe using math/rand is not the best idea for creating "random" secrets. Instead, you should probably use crypto/rand (which provides cryptographically random data).

I forked your project to use crypto/rand instead: https://github.com/bcleenders/gototp

I didn't do a pull request, because I changed your interface (since users no longer give a random generator as argument). Thus, if anyone is using your code they would get errors when rebuilding.

Feel free to pull if you don't think that's a problem, though...

PS: still nice to have your code available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant