Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook is leaking feed name #1407

Closed
tricki opened this issue Feb 15, 2024 · 2 comments
Closed

Webhook is leaking feed name #1407

tricki opened this issue Feb 15, 2024 · 2 comments
Assignees
Labels

Comments

@tricki
Copy link

tricki commented Feb 15, 2024

Description

When calling the webhook with a feed's ID (/index.php?p=actions/feed-me/feeds/run-task&direct=1&feedId=FEED_ID&passkey=) the title tag contains the feed's title, even with a wrong or missing passkey.

Should be a quick fix here:

<title>{{ 'Feed Me - {name} has started processing'|t('feed-me', { name: feed.name }) }}</title>

Steps to reproduce

n/a

Additional info

  • Craft version: Craft Pro 4.5.13
  • PHP version: 8.0.30
  • Database driver & version: n/a
  • Plugins & versions: Feed Me | 5.3.0
@i-just
Copy link
Contributor

i-just commented May 16, 2024

Hi, thanks for reporting! I raised a PR for this.

@i-just i-just self-assigned this May 16, 2024
@angrybrad
Copy link
Member

Merged and will be included in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants