Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computation of the projection variables G,D, C should have their own function #271

Open
aliutkus opened this issue Jan 9, 2018 · 2 comments

Comments

@aliutkus
Copy link

aliutkus commented Jan 9, 2018

right now, the code in _project and _project_images is very redundant for no reason,

furthermore, there are cases where we want to compute these variables without doing the actual filtering, as I believe we should do for the frame_wise eval

@bmcfee
Copy link
Collaborator

bmcfee commented Jan 10, 2018

IIRC the reason for this was to keep the translation from the matlab implementation as direct as possible. Maybe @dawenl can comment?

@aliutkus
Copy link
Author

I am in the process of working on these two recent issues I opened, I will keep you posted !

@faroit faroit mentioned this issue Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants