Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bss_eval_images_framewise should precompute the projection matrices #270

Open
aliutkus opened this issue Jan 9, 2018 · 1 comment
Open

Comments

@aliutkus
Copy link

aliutkus commented Jan 9, 2018

When calling separation.bss_eval_images_framewise, I believe that the projection matrix should be computed once and for good on the whole signal, instead of being computed anew at each frame as I understand is done now

@faroit faroit mentioned this issue Feb 2, 2018
@carlthome
Copy link
Contributor

Wow, yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants