Refactor 18 patterns

[Vitaly-Protasov]

Description of each pattern you can find here: PATTERNS.md

• 1) many_primary_ctors
• 2) method_chaining
• 3) method_siblings
• 4) multiply_try
• 5) nested_blocks
• 6) nested_loop
• 7) non_final_attribute
• 8) null_check
• 9) partial_synchronized
• 10) private_static_method
• 11) protected_method
• 12) public_static_method
• 13) redundant_catch
• 14) send_null
• 15) string_concat
• 16) this_finder
• 17) var_decl_diff
• 18) var_siblings

[aravij]

I think last patterns should be distributed the next way:

• @Vitaly-Protasov can take nesting_block and nesting_loop (last one should be deleted, check my comment in Clarify Nested Blocks pattern #562).
• I am currently working with grouping statements by scope and providing JavaLangImproved functionality. I consider to take patterns, which use it:
  • partial_synchronized
  • redundant_catch
  • var_decl_diff
• In order to spread the knowledge of using new ast_framework, @lyriccoder could take the rest of the patterns:
  • send_null
  • this_finder

This will finish our epic patterns refactoring (but not metrics!).

[Vitaly-Protasov]

I think last patterns should be distributed the next way:

• @Vitaly-Protasov can take nesting_block and nesting_loop (last one should be deleted, check my comment in Clarify Nested Blocks pattern #562).

• I am currently working with grouping statements by scope and providing JavaLangImproved functionality. I consider to take patterns, which use it:

  • partial_synchronized
  • redundant_catch
  • var_decl_diff

• In order to spread the knowledge of using new ast_framework, @lyriccoder could take the rest of the patterns:

  • send_null
  • this_finder

This will finish our epic patterns refactoring (but not metrics!).

I have almost finished "redundant_catch". may i take this?

[aravij]

@Vitaly-Protasov Yep, no problem.