Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little cleaning up of the Dockerfile #55

Open
esciara opened this issue Sep 18, 2017 · 0 comments 路 May be fixed by #56
Open

A little cleaning up of the Dockerfile #55

esciara opened this issue Sep 18, 2017 · 0 comments 路 May be fixed by #56

Comments

@esciara
Copy link

esciara commented Sep 18, 2017

Hi @cptactionhank ,

Quite impressed about the automation of the docker images creation you put in place here, I must say... Cool stuff ! 馃憤 .

Not sure about the initial history of your Dockerfile (and the other atlassian Dockerfile you initiated), but I could find some changes made the official Atlassian Dockerfile (at least up to version 6.3 as they are moving to Alpine after that) that includes some cleanup that might be interesting to introduce here, and that will not change the behavior of the image:

  • Introduction of environment variables for:
    • daemon (RUN_USER and RUN_GROUP)
    • CONF_DOWNLOAD_URL
    • MYSQL_VERSION
    • MYSQL_DRIVER_DOWNLOAD_URL
  • usage of CONF_INSTALL and CONF_HOME in more places

What about adding them ? Will create a pull request.

Em

esciara added a commit to esciara/docker-atlassian-confluence that referenced this issue Sep 19, 2017
@esciara esciara linked a pull request Sep 19, 2017 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant