-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup unit tests routine #71
Comments
Well, the simplest way possible is to add GoogleTest as submodule and drop all that hand-maderoutine the Blizzard devs wrote. While this will be not real unit-tests (we need a running client for run), we can add basic unit-tests, too. |
https://github.com/Nickrader/cpp-sc2/tree/dev_unittest I started off trying to implement a unit test routine. I have since moved the goalpost to completing a sample, covering the different test types in the GTest framework. Think I'm far enough to open it up for feedback/future direction. Figured getting a sample done first would make it more accessible for future contributors. Currently still a work-in-progress. P.S. I've learned more about CMake recently, so I'll have to go over that again. |
First of all, this is definitely a good attempt and nice way to get useful experience.
I am totally ok if you wish to implement some points from this list as whole list could take a while. |
By the way, perhaps you may find Catch2 more convenient to use in tests: |
We have lots of code which could be tested in some way, e.g. the new filters. Unfortunately, the only tests we have are functional requiring launch of a game client.
This task is about setting up a number of small unit test suites to check at least the filters.
The text was updated successfully, but these errors were encountered: