Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-couple actions from TestConfig #1325

Open
p-offtermatt opened this issue Sep 25, 2023 · 0 comments
Open

De-couple actions from TestConfig #1325

p-offtermatt opened this issue Sep 25, 2023 · 0 comments
Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability scope: testing Code review, testing, making sure the code is following the specification.

Comments

@p-offtermatt
Copy link
Contributor

p-offtermatt commented Sep 25, 2023 •
edited

Right now, the actions are methods of the test config.
This seems strange, and we might want to refactor this in the future, for example actions could take configs as an input.
This is not high-priority, but if we refactor the e2e framework, this might be something to keep in mind.

See #1318
@p-offtermatt p-offtermatt added good first issue Good for newcomers scope: testing Code review, testing, making sure the code is following the specification. S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability labels Sep 25, 2023
@p-offtermatt p-offtermatt mentioned this issue Sep 25, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: 📥 F2: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p-offtermatt