Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-std cleanup #42

Open
3 of 4 tasks
ethanfrey opened this issue Jul 12, 2021 · 1 comment
Open
3 of 4 tasks

No-std cleanup #42

ethanfrey opened this issue Jul 12, 2021 · 1 comment
Labels
rust Issues pertaining to the Rust implementation

Comments

@ethanfrey
Copy link
Contributor

ethanfrey commented Jul 12, 2021

Follow up from #41

  • Enable the api.rs tests in no-std mode as well
  • Remove #![allow(dead_code)] and #![allow(unused_imports)] from lib.rs if possible
  • Fix clippy warnings and test in CI (currently compress.rs:10 recommends using matches!... but maybe only as I use 1.51 locally and we run with 1.42 in CI... let's stick with 1.42 compatibility)
  • Ensure ics23.rs can be regenerated via cargo protoc without breaking the build (Fix cargo protoc error #44)
@ethanfrey ethanfrey mentioned this issue Jul 12, 2021
4 tasks
@ethanfrey
Copy link
Contributor Author

I fixed some of this in #43

I know little about no-std, but would be happy for someone to fix the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Issues pertaining to the Rust implementation
Projects
None yet
Development

No branches or pull requests

2 participants