You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This test should be refactored to reduce setup/verification complexity.
Problem Definition
The test is trying to test many cases in addition to asserting various expected results. This has become difficult to maintain as new features tend to insert their setup/exp result assertions into the body of the for loop iterating over test cases.
Proposal
We should simplify rework this test to separate concerns. I don't have a concrete proposal atm, mostly opening for signaling. It's possible this might be achieved by cleaning up the main handlers to separate concerns (currently logic for if a recv is the source chain or not the source chain are bundled into the same handler rather than being brought into smaller private functions).
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Summary
This test should be refactored to reduce setup/verification complexity.
Problem Definition
The test is trying to test many cases in addition to asserting various expected results. This has become difficult to maintain as new features tend to insert their setup/exp result assertions into the body of the for loop iterating over test cases.
Proposal
We should simplify rework this test to separate concerns. I don't have a concrete proposal atm, mostly opening for signaling. It's possible this might be achieved by cleaning up the main handlers to separate concerns (currently logic for if a recv is the source chain or not the source chain are bundled into the same handler rather than being brought into smaller private functions).
For Admin Use
The text was updated successfully, but these errors were encountered: