Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: snapshot restoration don't restart if cometbft pick a different snapshot #16868

Closed
yihuang opened this issue Jul 7, 2023 · 1 comment · Fixed by #20380
Closed

[Bug]: snapshot restoration don't restart if cometbft pick a different snapshot #16868

yihuang opened this issue Jul 7, 2023 · 1 comment · Fixed by #20380
Assignees
@lucaslopezf
Labels
S:zondax Squad: Zondax T:Bug

Comments

@yihuang
Copy link
Collaborator

yihuang commented Jul 7, 2023

Summary of Bug

11:27AM ERR Timed out waiting for snapshot chunks, rejected snapshot format=2 hash="�c$\td�7\"F��%�\fF��\x0f8q�\x05�C\x18W=\x04�U\x06�" height=12340000 module=statesync
11:27AM INF VerifyHeader hash=E07127384E22643A06CBCF1E7317503FED7ADD17033ABCE72C46F0C235D3ABB1 height=12341001 module=light
11:27AM INF VerifyHeader hash=FE89EB79B37CD746967113B1EEA4F8DB4BD088AB73B81508DC9A3A1D985D685C height=12341002 module=light
11:27AM INF Offering snapshot to ABCI app format=2 hash="r��Ɇ\x1e�\a�ϥ_�����ku\x00��\vX��\x15+u&s�" height=12341000 module=statesync
11:27AM ERR failed to restore snapshot err="a restore operation is in progress: conflict" format=2 height=12341000
11:27AM ERR State sync failed err="state sync aborted" module=statesync

During state sync, when cometbft timeout downloading a snapshot, it rejects the snapshot and pick a different one automatically, but sdk will complain a restore operation is in progress:, and can't proceed.

Version

all versions I believe.

Steps to Reproduce

do state sync in slow network.

Proposal

We should automatically reset the old restoration when a new snapshot is offered.
@yihuang yihuang added the T:Bug label Jul 7, 2023
@alexanderbez
Copy link
Contributor

Thanks @yihuang!

@lucaslopezf lucaslopezf self-assigned this May 2, 2024
@educlerici-zondax educlerici-zondax added the S:zondax Squad: Zondax label May 2, 2024
This was referenced May 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucaslopezf lucaslopezf

Labels
S:zondax Squad: Zondax T:Bug
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
5 participants
@yihuang @alexanderbez @lucaslopezf @tac0turtle @educlerici-zondax