Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing http_listen_port doesn't change ServiceMonitor podAnnotations values #410

Open
nschad opened this issue Oct 25, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nschad
Copy link
Collaborator

nschad commented Oct 25, 2022

We should update podAnnotations value if http_listen_port changes.

Original Comment:
Another concern I have -- and this is not entirely your fault because other deployments in this chart make the same mistake -- is that if http_listen_port is changed, this pod annotation will need to be changed to match.

server:
http_listen_port: 8080

It would be easier for the user if this annotation was populated by the value. You could support references in values by using tpl near toYaml. Something like {{- tpl (toYaml .) $ | nindent 8 }}.

Not a blocker, since this is already inconsistent throughout the chart.

Originally posted by @kd7lxl in #407 (comment)

@nschad nschad added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant