add workflow to generate README.md #188
Conversation
nschad
added
documentation
|
We will have to test it here but maybe this will do the trick on:
push:
paths-ignore:
- 'README.md*'
- 'docs/**'
- 'tools/**'
branches:
// kinda pointless, nobody should ever push to main/master
- main
- master
pull_request:and readme.yml workflow on:
push:
paths:
- 'README.md*'
- values.yaml
pull_request:Also I am not completely sure what happens when the ci test workflow is not run the 2nd time. Is the check just skipped? Is it marked as failed? Does the infinite-loop protection not even bother to check if it has to run the workflow (then it wouldn't work anyway)? |
Yes, it is just skipped, so it stays 🟠 indefinitely. |
BTW, this would run any time a PR was merged to |
yep thats why I added the comment. I am gonna ask some people, maybe somebody has a bright idea |
nschad
force-pushed
the
generate-readme
branch
from
98dd93a
to
606a056
Compare
| with: | ||
| add: README.md | ||
| default_author: github_actions | ||
| message: "[skip ci] generate README.md" |
There was a problem hiding this comment.
this should fix our infinite-loop problem @kd7lxl
nschad
force-pushed
the
generate-readme
branch
from
682f7b0
to
567bb68
Compare
Signed-off-by: Tom Hayward <thayward@infoblox.com> improve CI rules Signed-off-by: ShuzZzle <niclas.schad@gmail.com>
nschad
force-pushed
the
generate-readme
branch
from
a146fd6
to
041a0fd
Compare
|
Alright I think its fine currently how it is @kd7lxl |
|
lgtm |
This reverts commit 6620fde. Signed-off-by: Tom Hayward <thayward@infoblox.com>
This reverts commit 6620fde. Signed-off-by: Tom Hayward <thayward@infoblox.com>
…exproject#217) This reverts commit 6620fde. Signed-off-by: Tom Hayward <thayward@infoblox.com> Signed-off-by: Dan Constantinescu <dconstantinescu@blackberry.com>
What this PR does:
This adds a Github Action workflow to automate running
make(helm-docs) on each PR and committing any changes.This is a continuation of the work in #183.
Github Actions workflows will not trigger on commits pushed by Github Actions (differentiated by the auto auth token), so this workflow will cause the Lint and Test workflow to not run. Since that is a required workflow, the PR cannot be merged until Lint and Test is triggered some other way, like closing and reopening the PR. I've left this PR in draft mode while we try to find the best solution to automate running
makewithout defeating the required PR status checks.Which issue(s) this PR fixes:
Fixes #187