Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default favicon.ico #68

Open
brockovercash opened this issue Sep 7, 2016 · 1 comment
Open

Add default favicon.ico #68

brockovercash opened this issue Sep 7, 2016 · 1 comment

Comments

@brockovercash
Copy link

Just like there is a default 404.html and dirlist.html, I think it would be beneficial to serve a default favicon.ico for when users are using the site to serve simple files. If nothing else, it helps keep logs clean of 404s.

I think it could be easily implemented in server.go:HandleNotFound and I am happy to submit a PR with what I can come up with, but I wanted to hear thoughts first.

@cortesi
Copy link
Owner

cortesi commented Sep 22, 2016

Yes, please - this sounds like a good improvement, and I'd certainly merge a patch that implements it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants