Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaps in boxes drawn with double frames #157

Open
VladimirMarkelov opened this issue Feb 17, 2023 · 4 comments
Open

Gaps in boxes drawn with double frames #157

VladimirMarkelov opened this issue Feb 17, 2023 · 4 comments
Labels
enhancement may be implemented as an enhancement

Comments

@VladimirMarkelov
Copy link

Thank you for the great font! I love it. The only small issue is that a few (not all) double frame characters are drawn with gaps.

Windows 10 Home, Font version 0.048 (I installed only 4 fonts: regular, bold, italic, and bold+italic):

image

I spotted the issue in Conemu with FAR running inside it. FAR uses double frames in the main window and the gaps at the bottom of the screen are always visible. I took an example from https://en.wikipedia.org/wiki/Box-drawing_character#Examples:

┌─┬┐  ╔═╦╗  ╓─╥╖  ╒═╤╕
│ ││  ║ ║║  ║ ║║  │ ││
├─┼┤  ╠═╬╣  ╟─╫╢  ╞═╪╡
└─┴┘  ╚═╩╝  ╙─╨╜  ╘═╧╛
┌───────────────────┐
│  ╔═══╗ Some Text  │▒
│  ╚═╦═╝ in the box │▒
╞═╤══╩══╤═══════════╡▒
│ ├──┬──┤           │▒
│ └──┴──┘           │▒
└───────────────────┘▒
 ▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒

In tried few more applications(including Notepad++ and gVim). The boxes above are displayed with gaps everywhere. On another laptop (different laptop brand and Windows version), the gaps are visible, too. I do not have MacOS at hand, so I cannot check it there. Changing the size of the font did not fix anything (moreover, on small sizes around 5-6, the gaps appears even for single frames, but I doubt 5-6 font size is usable, so it is not a problem at all).

It is a screenshot from Notepad++. As you see, only some bottom box parts have gaps. Top and middle ones are fine:

image

I found an old closed issue #109 . The issue suggested to remove ASCII versions of the font. In my case, I do not have any of them(see the first screenshot). I started using your font since version 0.047 and then updated to 0.048. Both times I installed the same 4 font files.

If the issue is not reproducible at your machine, no problem - I can live with gaps 😄

Thank you!

@VladimirMarkelov VladimirMarkelov changed the title Gaps in boxes drown with double frames Gaps in boxes drawn with double frames Feb 17, 2023
@cormullion
Copy link
Owner

Hi, Vladimir, thanks for the report!

I could be wrong, but I'm guessing that you have the line spacing/leading set to 1.2 or more.

As far as I know most fonts won't draw boxes that connect vertically once the line spacing gets above a certain value, 1.2 here. (I've not found one yet.)

IBM Plex Mono:

boxes-plex

Cascadia Code:

boes-cascadea

Fira Code:

boxes-firacode

Some terminal applications (wezterm, kitty, perhaps) provide you with an option for drawing box characters directly, rather than relying on a font's box character drawing set. These will be drawn correctly, because the terminal knows exactly how widely separated the lines are, even if the font doesn't.

Having said that - if these other fonts don't show gaps on your system but JuliaMono does, then I confess I'm puzzled as to the cause, and solution... 🤔

@VladimirMarkelov
Copy link
Author

Yes, some fonts display the boxes correctly in Notepad++. Cascadia code looks similar to what your posted. But Fira Code looks good:

image

I tried other fonts, and found fonts that shows correctly: Courier New, Dejavu Sans Mono, Liberation Mono, Victor Mono and a few more. Here is DejaVu Sans Mono:

image

and Victor Mono:

image

Some other fonts failed to show correct boxes: e.g, "Iosevka Fixed", "Input". "Hack"(though, Hack has different trouble).

I have no clue why it happens, too 😄 Thank for trying to help. It is a tiny trouble: do not waste much time on it. Feel free to close the issue.

@cormullion
Copy link
Owner

Thanks for the research. It’s puzzling. I wonder whether font hinting is contributing to the confusion… When I’m in “font design mode” these little inconsistencies bother me. I’ll leave this open for now, in case any new information comes up.

@cormullion cormullion added the enhancement may be implemented as an enhancement label Feb 22, 2023
Copy link

github-actions bot commented Dec 6, 2023

This issue has been open for 30 days with no activity.

@github-actions github-actions bot added stale and removed stale labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement may be implemented as an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants