Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Docker image for 1.11.3 #6661

Open
chrisohaver opened this issue May 1, 2024 · 6 comments
Open

Missing Docker image for 1.11.3 #6661

chrisohaver opened this issue May 1, 2024 · 6 comments
Labels

Comments

@chrisohaver
Copy link
Member

The docker image for CoreDNS release 1.11.3 is not available due to persistent issues in the CoreDNS release process.
Once these issue are resolved, the image will be made available.

@jauderho
Copy link

jauderho commented May 1, 2024

For some reason, this is also not being tagged as the latest release when you go to the releases page.

@chrisohaver
Copy link
Member Author

For some reason, this is also not being tagged as the latest release when you go to the releases page.

This because 1.11.3 is not fully released. The docker images are not published, so the release is not available. The latest release actually available is still 1.11.1.

@dafanasiev
Copy link

NOTE: right now there is no way to detect latest release using github api releases-list endpoint (https://api.github.com/repos/coredns/coredns/releases) because both draft and prerelease are false:

# curl https://api.github.com/repos/coredns/coredns/releases | jq '.[] | select(.name=="v1.11.3")'

{
  "url": "https://api.github.com/repos/coredns/coredns/releases/153656321",
  "assets_url": "https://api.github.com/repos/coredns/coredns/releases/153656321/assets",
  "upload_url": "https://uploads.github.com/repos/coredns/coredns/releases/153656321/assets{?name,label}",
  "html_url": "https://github.com/coredns/coredns/releases/tag/v1.11.3",
  "id": 153656321,
  "author": {....},
  "node_id": "RE_kwDOAzt_0s4JKJwB",
  "tag_name": "v1.11.3",
  "target_commitish": "a7ed346585e30b99317d36e4d007b7b19a228ea5",
  "name": "v1.11.3",
  "draft": false,
  "prerelease": false,
  "created_at": "2024-04-26T19:08:47Z",
  "published_at": "2024-05-01T12:01:11Z",
  "assets": [....],
  "tarball_url": "https://api.github.com/repos/coredns/coredns/tarball/v1.11.3",
  "zipball_url": "https://api.github.com/repos/coredns/coredns/zipball/v1.11.3",
  "body": "This release contains some new features, bug fixes, and package updates. Because of the deployment issues with the previous release, all changed features from 1.11.2 have been included in this release.\r\nNew features include:\r\n* When the _forward_ plugin receives a malformed upstream response that overflows,\r\n  it will now send an empty response to the client with the truncated (TC) bit set to prompt the client\r\n  to retry over TCP.\r\n* The _rewrite_ plugin can now rewrite response codes.\r\n* The _dnstap_ plugin now supports adding metadata to the dnstap `extra` field.\r\n\r\n## Brought to You By\r\n\r\nAmila Senadheera,\r\nBen Kochie,\r\nBenjamin,\r\nChris O'Haver,\r\nGrant Spence,\r\nJohn Belamaric,\r\nKeita Kitamura,\r\nMarius Kimmina,\r\nMichael Grosser,\r\nOndřej Benkovský,\r\nP. Radha Krishna,\r\nRahil Bhimjiani,\r\nSri Harsha,\r\nTom Thorogood,\r\nWillow (GHOST),\r\nYong Tang,\r\nYuheng,\r\nZhizhen He,\r\nguangwu,\r\njourney-c,\r\npschou\r\nTed Ford\r\n\r\n## Noteworthy Changes\r\n\r\n* plugin/tls: respect the path specified by root plugin (https://github.com/coredns/coredns/pull/6138)\r\n* plugin/auto: warn when auto is unable to read elements of the directory tree (https://github.com/coredns/coredns/pull/6333)\r\n* plugin/etcd: the etcd client adds the DialKeepAliveTime parameter (https://github.com/coredns/coredns/pull/6351)\r\n* plugin/cache: key cache on Checking Disabled (CD) bit (https://github.com/coredns/coredns/pull/6354)\r\n* plugin/forward: Use the correct root domain name in the forward plugin's health checks (https://github.com/coredns/coredns/pull/6395)\r\n* plugin/forward: Handle UDP responses that overflow with TC bit (https://github.com/coredns/coredns/pull/6277)\r\n* plugin/rewrite: fix multi request concurrency issue in cname rewrite (https://github.com/coredns/coredns/pull/6407)\r\n* plugin/rewrite: add rcode as a rewrite option (https://github.com/coredns/coredns/pull/6204)\r\n* plugin/dnstap: add support for \"extra\" field in payload (https://github.com/coredns/coredns/pull/6226)\r\n* plugin/cache: fix keepttl parsing (https://github.com/coredns/coredns/pull/6250)\r\n* Return RcodeServerFailure when DNS64 has no next plugin (https://github.com/coredns/coredns/pull/6590)\r\n* Change the log flags to be a variable that can be set (https://github.com/coredns/coredns/pull/6546)\r\n* Bump go version to 1.21 (https://github.com/coredns/coredns/pull/6533)\r\n* replace the mutex locks in logging with atomic bool for the \"on\" flag (https://github.com/coredns/coredns/pull/6525)\r\n* Enable Prometheus native histograms (https://github.com/coredns/coredns/pull/6524)\r\n",
  "reactions": {....}
}
# curl https://api.github.com/repos/coredns/coredns/releases | jq '.[] | select(.name=="v1.11.1")'
{
  "url": "https://api.github.com/repos/coredns/coredns/releases/117360174",
  "assets_url": "https://api.github.com/repos/coredns/coredns/releases/117360174/assets",
  "upload_url": "https://uploads.github.com/repos/coredns/coredns/releases/117360174/assets{?name,label}",
  "html_url": "https://github.com/coredns/coredns/releases/tag/v1.11.1",
  "id": 117360174,
  "author": {.....},
  "node_id": "RE_kwDOAzt_0s4G_sYu",
  "tag_name": "v1.11.1",
  "target_commitish": "ae2bbc29be1aaae0b3ded5d188968a6c97bb3144",
  "name": "v1.11.1",
  "draft": false,
  "prerelease": false,
  "created_at": "2023-08-15T19:30:32Z",
  "published_at": "2023-08-15T20:00:30Z",
  "assets": [.....],
  "tarball_url": "https://api.github.com/repos/coredns/coredns/tarball/v1.11.1",
  "zipball_url": "https://api.github.com/repos/coredns/coredns/zipball/v1.11.1",
  "body": "This release fixes a major performance regression introduced in 1.11.0 that affected DoT (TLS) forwarded connections.\r\nIt also adds a new option to _dnstap_ to add metadata to the dnstap extra field, and fixes a config parsing bug in _cache_.\r\n\r\n## Brought to You By\r\n\r\nChris O'Haver,\r\nP. Radha Krishna,\r\nYong Tang,\r\nYuheng,\r\nZhizhen He\r\n\r\n## Noteworthy Changes\r\n\r\n* Revert \"plugin/forward: Continue waiting after receiving malformed responses (https://github.com/coredns/coredns/pull/6014)\" (#6270)\r\n* plugin/dnstap: add support for \"extra\" field in payload (https://github.com/coredns/coredns/pull/6226)\r\n* plugin/cache: fix keepttl parsing (https://github.com/coredns/coredns/pull/6250)\r\n\r\n",
  "reactions": {......}
}

latest release can be fetched using this api : https://api.github.com/repos/coredns/coredns/releases/latest

Maybe coredns team should mark some releases as prerelease or draft....

@chrisohaver
Copy link
Member Author

Done. 1.11.3 now marked pre-release.

@tedaford
Copy link
Contributor

Who has permissions for the Dockerhub credentials? This would be simple to resolve in theory if someone accessible has access to those.

@chrisohaver
Copy link
Member Author

When I get some time, I'll enable actions in my fork and do a release to my personal docker account.
This should identify if the issue is with the build scripts or a bad credential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants