Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vine: Possibility of the manager sending a library to all connected workers during one FunctionCall scheduling #3785

Open
tphung3 opened this issue Apr 25, 2024 · 0 comments

Comments

@tphung3
Copy link
Contributor

tphung3 commented Apr 25, 2024

When a manager schedules a FunctionCall to a worker, it first checks the fitness of every worker to the FunctionCall (unless a short circuit condition is true which depends on the scheduling algorithm), then commits the FunctionCall to the best worker. However, the process of checking fitness may require sending a library to a worker that the FunctionCall is not necessarily scheduled to later. In the worst case, the manager can send a library to all connected workers, and the FunctionCall is scheduled to the last checked worker which happens to be the best one. So one FunctionCall now results in an overhead of N library deployments where N is the number of workers, while preferably should result in an overhead of at most 1 library deployment.

The cause is due to the process of sending a library in the checking step, which is before committing the FunctionCall to a worker.

The fix is likely to move the library sending step to the FunctionCall committing step, and the check should not send anything (read-only).

CC'ing relevant people @dthain @BarrySlyDelgado from #3780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant