Ignoring case in serde deserialization for config types

[danyal002]

Is your feature request related to a problem? Please describe.

One of the frustrations I have whilst using Convco is that if any of my merge commits suffixes use title case like "Feat" or "Fix" instead of "feat" and "fix", my entire workflow stops. I'd like Convco to ignore the case of the type. This is currently done in the deserialize_type method in /src/conventional/config.rs. Conventional commits does allow for "any casing to be used".

Describe the solution you'd like

We convert the r#type to lower case and then match in the deserialize_type method.

[hdevalke]

You probably are referring to this: https://github.com/convco/convco/blob/main/src/conventional/config.rs#L131?

I think the workaround would be to add in your config that Feat increments Minor and Fix increments Patch. I would have to check if there are other places to fix.

[danyal002]

Yes, I am indeed referring to that (https://github.com/convco/convco/blob/main/src/conventional/config.rs#L131).

It feels like a heavyweight thing to do to just work around a case sensitivity issue. It also doesn't fully solve the issue, e.g. if there's a typo like "feAt" or "fiX" or any other variation, we'd need a case for that too.

My suggested changes would be as follows:

Change

convco/src/conventional/config.rs

Line 123 in e4e1c83

.map(

till line 139 to:

.map(
                |PartialType {
                    r#type,
                    increment,
                    section,
                    hidden,
                }| {
                    let r#type = r#type.to_ascii_lowercase();
                    Type {
                        r#type: r#type.clone(),
                        increment: increment.unwrap_or(match r#type.as_str() {
                            "feat" => Increment::Minor,
                            "fix" => Increment::Patch,
                            _ => Increment::None,
                        }),
                        section,
                        hidden,
                    }
                },
            )

and change

convco/src/conventional/commits.rs

Line 79 in e4e1c83

let r#type = capts.name("type").map(|t| t.as_str().to_owned());

to:

let r#type = capts.name("type").map(|t| http://t.as_str().to_ascii_lowercase());

What do you think?

[hdevalke]

I think it is good that convco check does check the case as it makes the commit messages consistent.

Do you only have issues with merge commits (commit with more than 1 parent)? There is an option to ignore merge commits.