You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To Reproduce
Steps to reproduce the behavior:
❯ convco version
7.0.0
❯ git sparse-checkout init --cone
❯ convco version
unsupported extension name extensions.worktreeconfig; class=Repository (6)
unsupported extension name extensions.worktreeconfig; class=Repository (6)
Expected behavior
No error, and if possible (depending on paths) still print the version
or, send error to stderr, and not fail.
Recovery from
❯ git sparse-checkout disable
and remove the added extenstion entry. Even if the value is "false" it will still error.
If there is an error opening the repo, I don't understand why the exit code should be 0.
In gfold, the workaround returns from the function, but does not have a repo instance. So if the same workaround is done, it will not be possible to calculate the version.
So I think what convco does now is the right thing
convco does the right thing yes, however, the underlying issue in libgit2 means that convco cannot be used on repositories that use worktreeconfig git extensions.
Describe the bug
Underlying library
libgit2
does not support repositories that use sparse-checkout(ref: libgit2/libgit2#6044)
This is for libgit2 to resolve, however, there seems to be a "protective" approach that convco needs to do, until libgit2 resolved the issue.
(gfold had to do the same - JohnFredok/gfold@667d927)
To Reproduce
Steps to reproduce the behavior:
❯ convco version
7.0.0
❯ git sparse-checkout init --cone
❯ convco version
unsupported extension name extensions.worktreeconfig; class=Repository (6)
unsupported extension name extensions.worktreeconfig; class=Repository (6)
Expected behavior
No error, and if possible (depending on paths) still print the version
or, send error to stderr, and not fail.
Recovery from
❯ git sparse-checkout disable
and remove the added extenstion entry. Even if the value is "false" it will still error.
The text was updated successfully, but these errors were encountered: