Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve releasing #143

Open
hdevalke opened this issue Aug 27, 2023 · 4 comments
Open

Improve releasing #143

hdevalke opened this issue Aug 27, 2023 · 4 comments
Labels
ci enhancement New feature or request

Comments

@hdevalke
Copy link
Collaborator

Currently releasing is done manual.
This process could be automated using a github action.

Manual steps:

  1. running cargo release $(convco version --bump) --execute on the master branch (needs git access and crate io credentials)
  2. download all binaries from the Build binary action
  3. create a new release from the tag pushed by (1)
  4. upload all downloaded artifacts from (2)
@taorepoara
Copy link

In my opinion creating the release should not be part of this project since it's easy do them manually. A simple doc guide should be enough.

I think that what make convco great is it minimalism.

If you start manage GitHub releases, why don't you manage GitLab releases, and then why don't you manage other things with plugins, and boom, you're just a Rust Semantic Release...

@hdevalke
Copy link
Collaborator Author

Thanks for your input. This is more about releasing convco itself then releasing applications using convco. It is not the goal to add a convco release sub command.

The main goal is to make it less time consuming for myself to release convco

@taorepoara
Copy link

Oh sorry for my misunderstanding ^^
Here is one of our GitHub action file for a Rust CLI to get inspired: https://github.com/lenra-io/lenra_cli/blob/main/.github/workflows/build_ci.yml

We are not using convco yet (because we have lot to do), but it could help you creating your own.

hdevalke added a commit that referenced this issue Mar 8, 2024
This adds a manual workflow to run cargo-release.
A changelog will be created, the crate will be published and a tag will
be created.
The release workflow will trigger as a new tag is created.

Refs: #143
hdevalke added a commit that referenced this issue Mar 8, 2024
This adds a manual workflow to run cargo-release.
A changelog will be created, the crate will be published and a tag will
be created.
The release workflow will trigger as a new tag is created.

Refs: #143
@hdevalke
Copy link
Collaborator Author

hdevalke commented Mar 8, 2024

A manual workflow has been added to trigger a release.
It does run cargo-release and creates a new tag (0.5.1 has been released this way)
However, the build binaries workflow does not trigger automatically.

So next steps:

  • trigger build binaries
  • improve build binaries workflow to also create a release in case it was not manually triggered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants