Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard API #1388

Open
wolftobias opened this issue Aug 31, 2021 · 2 comments
Open

Wizard API #1388

wolftobias opened this issue Aug 31, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@wolftobias
Copy link

For the Wizard.java class, please make the dialog variable protected or provide a setter.
Some people want to change some dialog properties e.g. window size, resizable or set a window icon.
Now I even cannot subclass it!

@Maxoudela
Copy link
Collaborator

Can you provide a PR?

@Maxoudela Maxoudela added the enhancement New feature or request label Sep 21, 2021
@ianrenton
Copy link

Hi, I have been looking for a way to access the inner Dialog object of a Wizard, in my case to prevent it being modal. It seems that elevating Wizard's getDialog() method (currently package-private to allow it to be unit tested) to public would solve my issue as well as this one, and related issues #756, #976, #999.

A setDialog() method could be useful as well, but it would have to incorporate some of the code in Wizard's constructor, and I'm not sure how we would handle the possibility of it being called after the Wizard dialog had already been displayed.

Are you still happy to receive a PR for this? If so I will submit one for making getDialog() public, as I think that meets the need with the minimum of complication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants