Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SampleScanner should load samples from classpath and module path. #1310

Open
dlemmermann opened this issue Sep 30, 2020 · 0 comments · May be fixed by #1314
Open

SampleScanner should load samples from classpath and module path. #1310

dlemmermann opened this issue Sep 30, 2020 · 0 comments · May be fixed by #1314
Assignees
@eugener

Comments

@dlemmermann
Copy link
Collaborator

The latest release made changes to the way SampleScanner loads samples. It now loads via modules and the modules path. But not every application gets deployed this way. Apps using the build scripts found in our JPackageScript project deploy all jar files to the classpath as there were still too many issues for projects related to working with modules and the module path. Samples there can not be found.
@abhinayagarwal abhinayagarwal self-assigned this Sep 30, 2020
@eugener eugener linked a pull request Oct 10, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugener eugener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FXSampler: Scan Class path as well as Module Path eugener/controlsfx
3 participants
@eugener @abhinayagarwal @dlemmermann