Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup log messages #468

Open
yuva29 opened this issue Oct 26, 2016 · 3 comments
Open

Cleanup log messages #468

yuva29 opened this issue Oct 26, 2016 · 3 comments

Comments

@yuva29
Copy link
Contributor

yuva29 commented Oct 26, 2016

TTL locking messages should be isolated so that it doesn't interwind along with other messages.

Its little confusing to go over the messages in its current state.

time="2016-10-19T21:45:48Z" level=debug msg="Removing Use Lock: &config.UseMount{Volume:\"nfs/v5\", Hostname:\"mon0\", Reason:\"Mount\"}" time="2016-10-19T21:45:48Z" level=warning msg="Could not remove \"Mount\" lock for \"nfs/v5\"" time="2016-10-19T21:45:48Z" level=warning msg="Waiting 100ms for \"Mount\" lock on \"nfs/v5\" to free" time="2016-10-19T21:45:49Z" level=debug msg="Removing Use Lock: &config.UseMount{Volume:\"nfs/v5\", Hostname:\"mon0\", Reason:\"Mount\"}"

@erikh
Copy link
Contributor

erikh commented Oct 26, 2016

set the log level to info.

@yuva29
Copy link
Contributor Author

yuva29 commented Oct 26, 2016

I would rather see 2 lines of high level message saying

Waiting for lock {Volume:\"nfs/v5\", Hostname:\"mon0\", Reason:\"Mount\"}
Acquiring lock ...

all the other detailed messages should be separated out.

@yuva29 yuva29 changed the title cleanup log messages Cleanup log messages Oct 26, 2016
@erikh
Copy link
Contributor

erikh commented Oct 26, 2016

they are. the log level above are "debug" and "warning"

This will give you more info on syslog levels, which are relevant (but not used) here: https://www.google.com/search?client=ubuntu&channel=fs&q=syslog+log+levels&ie=utf-8&oe=utf-8

But essentially, when loglevels are set to info, the warning class of log entry will only show up. debug is enabled right now in the binary.

My point is, all these debug logs are very relevant for testing and evaluating the health of volplugin while allowing us to filter these messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants