Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Entity list item isSelected prop #2312

Closed

Conversation

mgueyraud
Copy link

@mgueyraud mgueyraud commented Nov 2, 2022

Purpose of PR

Closes #2077.

Add a prop isSelected to the entity list item, and the corresponding styles of it. Basically the same way as the card works.

So, to maintain the consistency of the EntityListItem component, I only override the backgroundColor and the boxShadow when it has the isSelected prop, so it looks like this by itself:

Screen Shot 2022-11-01 at 22 19 54

And when it's used within a EntityList component, that component is in charge to add more styles such as left, right and top borders.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2022

⚠️ No Changeset found

Latest commit: 8745ff2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 2, 2022

@mgueyraud is attempting to deploy a commit to the Contentful Apps Team on Vercel.

A member of the Team first needs to authorize it.

@denkristoffer denkristoffer requested a review from a team as a code owner November 4, 2022 11:21
@mgueyraud mgueyraud marked this pull request as draft November 5, 2022 17:06
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Dec 6, 2022
@denkristoffer
Copy link
Collaborator

Thanks for the contribution @mgueyraud! I will be closing this until or if it's ever ready. That's not meant to pressure you into working on it at all by the way, but there's no need to keep it laying around in the current state 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark when there was no activity for a set period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal - EntityListItem selection
2 participants