Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Be able to use SingleMediaEditor with JSON object field #931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Be able to use SingleMediaEditor with JSON object field #931

wants to merge 1 commit into from

Conversation

drager
Copy link

@drager drager commented Nov 18, 2021

Fixes #929

@drager drager requested review from a team as code owners November 18, 2021 07:12
@drager drager requested review from suevalov and bgutsol and removed request for a team November 18, 2021 07:12
DanweDE
DanweDE reviewed Nov 19, 2021
View reviewed changes
packages/reference/src/common/SingleReferenceEditor.tsx
@@ -81,7 +81,7 @@ export function SingleReferenceEditor(
<Editor
{...props}
key={`${externalReset}-reference`}
entityId={value ? value.sys.id : ''}
entityId={value ? value?.sys?.id : ''}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this work down the road, let's say in a couple of months, as folks might wonder why this is required and might change it back, consider adding a unit test for your use case.

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

Marking pull request as stale since there was no acitivty for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Aug 5, 2022
@aaron5670
Copy link

Status of this PR? 😄

@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Aug 10, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Marking pull request as stale since there was no acitivty for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanweDE DanweDE DanweDE left review comments

@suevalov suevalov Awaiting requested review from suevalov suevalov was automatically assigned from contentful/team-isotopes

@bgutsol bgutsol Awaiting requested review from bgutsol bgutsol was automatically assigned from contentful/team-isotopes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SingleMediaEditor doesn't work with JSON object field type
3 participants
@drager @aaron5670 @DanweDE