Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken support for Containerfile #929

Open
uosis opened this issue May 7, 2024 · 0 comments
Open

Broken support for Containerfile #929

uosis opened this issue May 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@uosis
Copy link

uosis commented May 7, 2024

Describe the bug

#686 broke support for using Containerfile instead of Dockerfile for builds. Dockerfile hardcoded here:

https://github.com/containers/podman-compose/pull/686/files#diff-956dd8b5765533c7e8f5bb94c8a1b4735dfcfd9cff54829f3494b87460fab50bR1297

which causes this logic to be skipped:

https://github.com/containers/podman-compose/blob/main/podman_compose.py#L2238

To Reproduce

Try to build any compose file that has build: . or similar and Containerfile instead of Dockerfile.

Expected behavior
Containerfile to be detected as before.
Actual behavior
Containerfile not detected

Output

$ podman-compose version
podman-compose version 1.1.0
podman version 5.0.2

Environment:

  • OS: Linux
@uosis uosis added the bug Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant