Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/fastbar.rs rendering is different on Windows git-bash than CMD or PowerShell #634

Closed
DBY047 opened this issue Feb 18, 2024 · 3 comments

Comments

@DBY047
Copy link

DBY047 commented Feb 18, 2024

  • OS: Windows 10
  • Indicateif version: 0.17.8
  • Shells: Git Bash vs Powershell or CMD (Window Terminal)

I saw a similar behavior on a program I wrote. Whether I use finish or finish_and_clear, printLn! called after is printed on the same line as the progress bar. I saw the same behavior on fastbar example.

Rendering on Command Prompt:
image

Redering on git bash
image

Also, it looks like wide_bar is not handled the same way on all terminals. I can't find out what to change on my code or on git-bash configuration so wide_bar is rendered wide.

Thanks,

@djc
Copy link
Collaborator

djc commented Feb 19, 2024

Sorry, I won't have time to look into this. Open to reviewing a PR if you figure out why this happens, though!

@DBY047
Copy link
Author

DBY047 commented Feb 21, 2024

@djc Both issue are caused by GetConsoleScreenBufferInfo in console/mod.rs returning 0.

I found a fix here mintty/mintty#1188 (comment) that fixes both wide_bar not beeig wide and the printLn! not beeing printed as a new line.

@DBY047 DBY047 closed this as completed Feb 21, 2024
@djc djc closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@djc
Copy link
Collaborator

djc commented Feb 21, 2024

Glad you were able to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants