Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2183 switch to licence expression + repo info #2192

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

thompson-tomo
Copy link
Contributor

This sets additional package info and switch to licence expression rather than url. Also lint csproj to be consistantly tabbed.

closes #2183

Copy link

cla-assistant bot commented Feb 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 22, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Left some minor nitpicks.

src/Confluent.Kafka/Confluent.Kafka.csproj Outdated Show resolved Hide resolved
src/Confluent.Kafka/Confluent.Kafka.csproj Outdated Show resolved Hide resolved
src/Confluent.Kafka/Confluent.Kafka.csproj Outdated Show resolved Hide resolved
@thompson-tomo
Copy link
Contributor Author

Will make the changes tomorrow/tonight.

@thompson-tomo thompson-tomo force-pushed the chore/#2183_SwitchToLicenceExpression branch from 53daeb0 to 0f2842c Compare April 8, 2024 10:21
Copy link
Member

@anchitj anchitj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I've pushed a commit to fix some typos and tabs with spaces.

@thompson-tomo thompson-tomo force-pushed the chore/#2183_SwitchToLicenceExpression branch 12 times, most recently from 850d14c to 24094db Compare May 8, 2024 13:23
@thompson-tomo thompson-tomo force-pushed the chore/#2183_SwitchToLicenceExpression branch from 24094db to 8fea155 Compare May 8, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to LicenceExpression
2 participants