Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only depend on System.Memory when needed #2181

Open
thompson-tomo opened this issue Feb 4, 2024 · 0 comments · May be fixed by #2193
Open

Only depend on System.Memory when needed #2181

thompson-tomo opened this issue Feb 4, 2024 · 0 comments · May be fixed by #2193

Comments

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Feb 4, 2024 •
edited

summary

On newer TFM'S System.Memory is included as part of the framework hence the dependency is not needed.

Proposal

Adjust the conditions on the package dependency in Confluent.Kafka so that it won't be added for the newer TFM
thompson-tomo added a commit to thompson-tomo/confluent-kafka-dotnet that referenced this issue Feb 22, 2024
@thompson-tomo
confluentinc#2181 Remove System.Memory from Dotnet 6
02299db
@thompson-tomo thompson-tomo linked a pull request Feb 22, 2024 that will close this issue
Open
thompson-tomo added a commit to thompson-tomo/confluent-kafka-dotnet that referenced this issue May 8, 2024
@thompson-tomo
confluentinc#2181 Remove System.Memory from Dotnet 6
ab9947b
thompson-tomo added a commit to thompson-tomo/confluent-kafka-dotnet that referenced this issue May 8, 2024
@thompson-tomo
confluentinc#2181 Remove System.Memory from Dotnet 6
3447ad9
thompson-tomo added a commit to thompson-tomo/confluent-kafka-dotnet that referenced this issue May 8, 2024
@thompson-tomo
confluentinc#2181 Remove System.Memory from Dotnet 6
8859e3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2181 Remove System.Memory from Dotnet 6 thompson-tomo/confluent-kafka-dotnet
1 participant
@thompson-tomo