Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in webhook of workflow and task statuses #131

Open
JCHacking opened this issue Apr 15, 2024 · 1 comment
Open

Error in webhook of workflow and task statuses #131

JCHacking opened this issue Apr 15, 2024 · 1 comment

Comments

@JCHacking
Copy link
Contributor

JCHacking commented Apr 15, 2024

Describe the bug
When conductor is configured without these 2 properties:

  • conductor.status-notifier.notification.headerPrefer
  • conductor.status-notifier.notification.headerPreferValue

The request is not a valid http

Details
Conductor version: 3.19.0

To Reproduce
Steps to reproduce the behavior:

  1. Configure conductor withtou conductor.status-notifier.notification.headerPrefer and conductor.status-notifier.notification.headerPreferValue
  2. Create workflow
  3. Start workflow
  4. See request sended by webhook is http invalid

Expected behavior
You should check that they have content before doing

headers.put(config.getHeaderPrefer(), config.getHeaderPreferValue());
@SSingh206
Copy link

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants