-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cheatsheet PDF download to cheatsheet page #13909
Added cheatsheet PDF download to cheatsheet page #13909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming aside, this looks great! Thank you, @kathatherine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being a stickler, could we name the file conda-24.4.0.pdf
like the other files in the folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a problem! I missed that the first time because I wasn't reading carefully enough. I appreciate you being a stickler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than Jannis's comment here (which I agree with), this looks good to go!
Also, one more thing, @jezdez, I deleted the old cheatsheet PDFs in the cheatsheet PR before this one. Your comment above makes me think we actually want to keep those. I can add them back in, if so. |
I know you were asking @jezdez but I want to add my opinion that I don't think that any of the old cheat sheets should be on that page, since a lot of them have outdated info and folks can go to an older version of the docs in order to access the previous cheat sheets (but I defer to what @jezdez thinks is best!). PS - I might be misunderstanding; if you're talking about reverting the deletion of an old cheat sheet from an older version of the docs, then yes please add it back! |
Oh I missed that. My worry is that someone was linking to the old files and it's now 404'ing. Maybe we could resolve that with a redirect instead? |
Gotcha, I missed the deletion, my only worry is breaking links to the old PDFs via the stable or latest docs builds that would end being a 404 without resolution. |
Gotcha. Apologies for the misunderstanding! I downloaded them from stable and added them back in. |
Description
Closes #13908.
Added cheatsheet PDF download to the new cheatsheet text page. I didn't add an extra folder or symlink back in just yet. I'm not sure if we are going to want to have a new PDF for each version or not.
I also added back in the tips from the PDF, since it'll be more directly comparable. These may or may not be helpful, but can probably be fit into the auto PDF once we figure all of that out.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?[ ] Add / update necessary tests?[ ] Add / update outdated documentation?