Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload.yml workflow #5339

Merged
merged 1 commit into from
May 13, 2024
Merged

Add upload.yml workflow #5339

merged 1 commit into from
May 13, 2024

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented May 13, 2024

Description

Port conda's upload.yml workflow that has been successfully used for three releases now to produce release tarballs with static sha256 hashes.

This will prevent the sha256 race condition that occurs when using GitHub's auto-generated release tarballs (see AnacondaRecipes/conda-build-feedstock#44 and conda-forge/conda-build-feedstock#226).

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

Fixes #5340

@kenodegard kenodegard requested a review from a team as a code owner May 13, 2024 20:26
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label May 13, 2024
@jakirkham
Copy link
Member

Opened an issue about this. Added a "fixes" note about in this PR's OP. Hope that is ok

Please feel free to add any additional context to that issue as needed

@kenodegard kenodegard merged commit 0311d83 into conda:main May 13, 2024
14 checks passed
@kenodegard kenodegard deleted the upload-workflow branch May 13, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Publish stable artifacts with checksums during release
4 participants