Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename variables named white* to allow* #4540

Open
Tracked by #4494
kenodegard opened this issue Jul 27, 2022 · 4 comments · May be fixed by #5301
Open
Tracked by #4494

Rename variables named white* to allow* #4540

kenodegard opened this issue Jul 27, 2022 · 4 comments · May be fixed by #5301
Assignees
@beeankha
Labels
backlog issue has been triaged but has not been earmarked for any upcoming release source::anaconda created by members of Anaconda, Inc. type::tech-debt identifies or resolves some technical debt

Comments

@kenodegard
Copy link
Contributor

kenodegard commented Jul 27, 2022 •
edited

Description

Derived from our inclusive language efforts (see #4494 and 7.1 of our styleguide).

@kenodegard said in #4494 (comment):
There are two white* variables in conda-build, both are recipe keywords: missing_dso_whitelist and runpath_whitelist.

Both keywords are also in use in mamaba/boa so we will need to offer similar modifications there.

Furthermore, since conda-build doesn't have an aliasing system like conda.base.context.Context does, this becomes a large enough change that I'm wondering if we should backlog the allow/deny rewording for now?

At the very least, the allow/deny rewording should be spun off from this epic into a separate effort.
@kenodegard kenodegard mentioned this issue Jul 27, 2022
Closed
8 tasks
@kenodegard kenodegard added backlog issue has been triaged but has not been earmarked for any upcoming release source::anaconda created by members of Anaconda, Inc. type::tech-debt identifies or resolves some technical debt labels Jul 27, 2022
@kenodegard kenodegard changed the title Rename any variables named white* to allow* Rename variables named white* to allow* Jul 27, 2022
@jakirkham
Copy link
Member

@jezdez, how do you think we should approach this one?

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Feb 8, 2024
@jakirkham
Copy link
Member

Not stale

@jakirkham jakirkham removed the stale [bot] marked as stale due to inactivity label Feb 8, 2024
@beeankha beeankha self-assigned this Mar 8, 2024
@beeankha beeankha added this to the 24.5.x milestone Mar 8, 2024
@beeankha beeankha assigned kenodegard and unassigned kenodegard Mar 8, 2024
@beeankha beeankha mentioned this issue Apr 19, 2024
Closed
@beeankha beeankha removed this from the 24.5.x milestone Apr 19, 2024
@beeankha beeankha linked a pull request Apr 19, 2024 that will close this issue
Draft
@beeankha
Copy link
Contributor

Quick note: The new recipe format Conda Enhancement Proposal (CEP 14) utilizes missing_dso_allowlist and rpath_allowlist as keys instead of missing_dso_allowlist and runpath_whitelist:

Screenshot 2024-04-19 at 3 02 49 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beeankha beeankha

Labels
backlog issue has been triaged but has not been earmarked for any upcoming release source::anaconda created by members of Anaconda, Inc. type::tech-debt identifies or resolves some technical debt
Projects
🧭 Planning
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inclusive language updates beeankha/conda-build
3 participants
@jakirkham @kenodegard @beeankha