Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conda-build to remove libarchive-style zstd:compression-level compression tuple #5206

Open
2 tasks done
dholth opened this issue Feb 29, 2024 · 0 comments
Open
2 tasks done
Labels
source::anaconda created by members of Anaconda, Inc. type::feature request for a new feature or capability

Comments

@dholth
Copy link
Contributor

dholth commented Feb 29, 2024

Checklist

  • I added a descriptive title
  • I searched open requests and couldn't find a duplicate

What is the idea?

While reading conda-build's source code I noticed

        cph_kwargs["compression_tuple"] = (
            ".tar.zst",
            "zstd",
            f"zstd:compression-level={metadata.config.zstd_compression_level}",
        )

This references a libarchive feature.

Now that conda-package-handling is using python-zstandard, we can set compression without string parsing. We could also allow auto-threads. We would need to require conda-package-handling >=2.

https://github.com/conda/conda-package-handling/blob/main/src/conda_package_handling/conda_fmt.py#L53-L60

Unfortunately the current conda-package-handling API would require us to instantiate a python-zstandard object ourselves, which would be unfortunate if -handling decided to change its preferred compression library.

@dholth dholth added type::feature request for a new feature or capability source::anaconda created by members of Anaconda, Inc. labels Feb 29, 2024
@dholth dholth changed the title Update conda-build to use conda-package-handling 2.0+ Update conda-build to remove libarchive-style zstd:compression-level compression tuple Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source::anaconda created by members of Anaconda, Inc. type::feature request for a new feature or capability
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant