Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing the option --build-id-pat="" to conda build does not work #4875

Open
2 of 3 tasks
travishathaway opened this issue May 8, 2023 · 1 comment
Open
2 of 3 tasks
Labels
good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward source::anaconda created by members of Anaconda, Inc. stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type

Comments

@travishathaway
Copy link
Contributor

travishathaway commented May 8, 2023

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

In our documentation for the deprecated --no-build-id option, it says that this should be done instead by using --build-id-pat="". This currently does not work and when inspecting the code, it's easy to see why:

old_build_id_t = self.build_id_pat if self.build_id_pat else "{n}-{v}_{t}"

and

build_id = self.build_id_pat if self.build_id_pat else "{n}-{v}_{t}"

In the above examples, which represent everywhere in the code this configuration option is used, passing and empty string "" would evaluate to false and the trigger the usage of "{n}-{v}_{t}" instead.

What should happen?

  • Fix this bug and add new test cases that cover it

Additional Context

This is was initially reported in response to concerns brought up in this issue:

@travishathaway travishathaway added type::bug describes erroneous operation, use severity::* to classify the type source::anaconda created by members of Anaconda, Inc. good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward labels May 8, 2023
Copy link

github-actions bot commented May 8, 2024

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue great for new contributors, code change is envisioned to be trivial/relatively straight-forward source::anaconda created by members of Anaconda, Inc. stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant